Wrong include for the codec base class #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working on a new version of the documentation generator tool, I found out that this plugin doesn't actually require the right base class for the codec. Since the doc tool actualy do dynamic ruby parsing the code need to be able to run. However, this problem cannot happen in a real world situation because the base class is loaded by other classes. Related: elastic/logstash#5715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on a new version of the documentation generator tool,
I found out that this plugin doesn't actually require the right base
class for the codec.
Since the doc tool actualy do dynamic ruby parsing the code need to be
able to run. However, this problem cannot happen in a real world situation
because the base class is loaded by other classes.
Related: elastic/logstash#5715