Skip to content

Replace WeakConcurrentMaps with SpanConcurrentHashMaps in gRPC plugin #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2021
Merged

Replace WeakConcurrentMaps with SpanConcurrentHashMaps in gRPC plugin #2081

merged 3 commits into from
Sep 13, 2021

Conversation

eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Aug 25, 2021 •
edited by zube bot
Loading

Implementing #2092 for the gRPC plugin

@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Aug 25, 2021
@eyalkoren eyalkoren changed the title Replace gRPC maps with ref-counting ones and reduce GC reliance Replace WeakConcurrentMaps with SpanConcurrentHashMaps where applicable Aug 25, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Aug 25, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-13T05:56:39.715+0000

  • Duration: 57 min 35 sec

  • Commit: 9c1c760

Test stats 🧪

Test Results
Failed 0
Passed 2396
Skipped 19
Total 2415

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2396
Skipped 19
Total 2415

@AlexanderWert AlexanderWert removed community Issues and PRs created by the community triage labels Aug 25, 2021
@eyalkoren eyalkoren changed the title Replace WeakConcurrentMaps with SpanConcurrentHashMaps where applicable Replace WeakConcurrentMaps with SpanConcurrentHashMaps in gRPC plugin Aug 29, 2021
@eyalkoren eyalkoren mentioned this pull request Aug 29, 2021
Closed
9 tasks
@eyalkoren eyalkoren requested a review from SylvainJuge August 29, 2021 08:38
@eyalkoren eyalkoren marked this pull request as ready for review August 29, 2021 08:38
@AlexanderWert AlexanderWert added this to the 7.16 milestone Aug 30, 2021
SylvainJuge
SylvainJuge approved these changes Sep 1, 2021
View reviewed changes
@eyalkoren eyalkoren merged commit 01a1468 into elastic:master Sep 13, 2021
@eyalkoren eyalkoren deleted the switch-to-SpanConcurrentHashMap branch September 13, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SylvainJuge SylvainJuge SylvainJuge approved these changes

Assignees

@eyalkoren eyalkoren

Labels
agent-java chore
Projects
None yet
Milestone
7.16
Development

Successfully merging this pull request may close these issues.
4 participants
@eyalkoren @apmmachine @SylvainJuge @AlexanderWert