Revert per-index collation version tracking feature.
authorThomas Munro <tmunro@postgresql.org>
Fri, 7 May 2021 08:17:42 +0000 (20:17 +1200)
committerThomas Munro <tmunro@postgresql.org>
Fri, 7 May 2021 09:10:11 +0000 (21:10 +1200)
commitec48314708262d8ea6cdcb83f803fc83dd89e721
treef5b7c82ea571ce78aaa355095dd588dce07349ff
parenta288d94c91e345ebeb10ac30f247270c8c8e380a
Revert per-index collation version tracking feature.

Design problems were discovered in the handling of composite types and
record types that would cause some relevant versions not to be recorded.
Misgivings were also expressed about the use of the pg_depend catalog
for this purpose.  We're out of time for this release so we'll revert
and try again.

Commits reverted:

1bf946bd: Doc: Document known problem with Windows collation versions.
cf002008: Remove no-longer-relevant test case.
ef387bed: Fix bogus collation-version-recording logic.
0fb0a050: Hide internal error for pg_collation_actual_version(<bad OID>).
ff942057: Suppress "warning: variable 'collcollate' set but not used".
d50e3b1f: Fix assertion in collation version lookup.
f24b1569: Rethink extraction of collation dependencies.
257836a7: Track collation versions for indexes.
cd6f479e: Add pg_depend.refobjversion.
7d1297df: Remove pg_collation.collversion.

Discussion: http://postgr.es/m/CA%2BhUKGLhj5t1fcjqAu8iD9B3ixJtsTNqyCCD4V0aTO9kAKAjjA%40mail.gmail.com
55 files changed:
doc/src/sgml/catalogs.sgml
doc/src/sgml/charset.sgml
doc/src/sgml/func.sgml
doc/src/sgml/ref/alter_collation.sgml
doc/src/sgml/ref/alter_index.sgml
doc/src/sgml/ref/create_collation.sgml
doc/src/sgml/ref/pgupgrade.sgml
doc/src/sgml/ref/reindex.sgml
src/backend/catalog/dependency.c
src/backend/catalog/heap.c
src/backend/catalog/index.c
src/backend/catalog/pg_collation.c
src/backend/catalog/pg_constraint.c
src/backend/catalog/pg_depend.c
src/backend/catalog/pg_type.c
src/backend/commands/collationcmds.c
src/backend/commands/statscmds.c
src/backend/commands/tablecmds.c
src/backend/nodes/copyfuncs.c
src/backend/nodes/equalfuncs.c
src/backend/optimizer/util/plancat.c
src/backend/parser/gram.y
src/backend/tcop/utility.c
src/backend/utils/adt/pg_locale.c
src/backend/utils/adt/pg_upgrade_support.c
src/backend/utils/cache/relcache.c
src/bin/pg_dump/pg_backup.h
src/bin/pg_dump/pg_dump.c
src/bin/pg_dump/pg_dump.h
src/bin/pg_upgrade/dump.c
src/bin/pg_upgrade/option.c
src/bin/pg_upgrade/pg_upgrade.h
src/bin/psql/tab-complete.c
src/include/catalog/catversion.h
src/include/catalog/dependency.h
src/include/catalog/index.h
src/include/catalog/pg_collation.h
src/include/catalog/pg_depend.h
src/include/catalog/pg_type.h
src/include/commands/collationcmds.h
src/include/nodes/parsenodes.h
src/include/utils/pg_locale.h
src/include/utils/rel.h
src/test/Makefile
src/test/locale/.gitignore
src/test/locale/Makefile
src/test/locale/t/001_index.pl [deleted file]
src/test/regress/expected/collate.icu.utf8.out
src/test/regress/expected/collate.linux.utf8.out
src/test/regress/expected/create_index.out
src/test/regress/expected/misc_sanity.out
src/test/regress/sql/collate.icu.utf8.sql
src/test/regress/sql/collate.linux.utf8.sql
src/test/regress/sql/create_index.sql
src/tools/pgindent/typedefs.list