Report stats when replaying XLOG_RUNNING_XACTS
authorAndres Freund <andres@anarazel.de>
Mon, 12 Jun 2023 22:06:12 +0000 (15:06 -0700)
committerAndres Freund <andres@anarazel.de>
Mon, 12 Jun 2023 22:06:39 +0000 (15:06 -0700)
commite3cb1a586cef746326eeabf36d103ea1136607f9
tree56a632afea994fe333da12ed11e482c75087e73a
parent7398e27224f173306e5b62977672b29f5553ee76
Report stats when replaying XLOG_RUNNING_XACTS

Previously stats in the startup process would only get reported during
shutdown of the startup process. It has been that way for a long time, but
became a lot more noticeable with the new pg_stat_io view, which separates out
IO done by different backend types...

While replaying after every XLOG_RUNNING_XACTS isn't the prettiest approach,
it has the advantage of being quite easy. Given that we're well past feature
freeze...

It's not a problem that we don't report stats more frequently with
wal_level=minimal, in that case stats can't be read before the stats process
has shut down.

Besides the above, this commit also changes pgstat_report_stat() to acquire
the timestamp with GetCurrentTimestamp() instead of
GetCurrentTransactionStopTimestamp().

Thanks to Melih Mutlu, Kyotaro Horiguchi for prototypes of other approaches to
solving this issue.

Reported-by: Fujii Masao <masao.fujii@oss.nttdata.com>
Discussion: http://postgr.es/m/5315aedc-fbca-1556-c5de-dc2e00b23a14@oss.nttdata.com
src/backend/storage/ipc/standby.c
src/backend/utils/activity/pgstat.c