Free disk space for dropped relations on commit.
authorThomas Munro <tmunro@postgresql.org>
Tue, 1 Dec 2020 00:46:27 +0000 (13:46 +1300)
committerThomas Munro <tmunro@postgresql.org>
Tue, 1 Dec 2020 01:54:49 +0000 (14:54 +1300)
commite00928de8d221435864c8f84421df988c0425ef7
tree62f6a127d53f964800d3be296a0c9f76fc4dd446
parent968a537b432eb19001ad5788023aabe0a009aa16
Free disk space for dropped relations on commit.

When committing a transaction that dropped a relation, we previously
truncated only the first segment file to free up disk space (the one
that won't be unlinked until the next checkpoint).

Truncate higher numbered segments too, even though we unlink them on
commit.  This frees the disk space immediately, even if other backends
have open file descriptors and might take a long time to get around to
handling shared invalidation events and closing them.  Also extend the
same behavior to the first segment, in recovery.

Back-patch to all supported releases.

Bug: #16663
Reported-by: Denis Patron <denis.patron@previnet.it>
Reviewed-by: Pavel Borisov <pashkin.elfe@gmail.com>
Reviewed-by: Neil Chen <carpenter.nail.cz@gmail.com>
Reviewed-by: David Zhang <david.zhang@highgo.ca>
Discussion: http://postgr.es/m/16663-fe97ccf9932fc800%40postgresql.org
src/backend/storage/smgr/md.c