Fix bug in pg_basebackup -F plain -R.
authorFujii Masao <fujii@postgresql.org>
Wed, 12 Feb 2020 00:08:22 +0000 (09:08 +0900)
committerFujii Masao <fujii@postgresql.org>
Wed, 12 Feb 2020 00:08:22 +0000 (09:08 +0900)
commitbe6221e9be234109aa261ea767c85f5e8cda90e8
treee7a17109919009cf417bcbdcd7e5aa0d399678ce
parente49d5ebbaebc3ecd6b495fda9518c2c2fac5c296
Fix bug in pg_basebackup -F plain -R.

Commit caba97a9d9 changed pg_basebackup -F plain -R so that
it overwrote postgresql.auto.conf in the backup, with new connection
setting. This could cause the existing postgresql.auto.conf settings
in the server to get lost unexpectedly. This is a bug.

This commit fixes the bug by making pg_basebackup -F plain -R
append the connection setting into postgresql.auto.conf in the backup.

Author: Fujii Masao
Reviewed-by: Sergei Kornilov
Discussion: http://postgr.es/m/250dcf2a-94e7-c05e-824a-73cfb38a48a4@oss.nttdata.com
src/fe_utils/recovery_gen.c