Fix handling Inf and Nan values in GiST pairing heap comparator
authorAlexander Korotkov <akorotkov@postgresql.org>
Sun, 8 Sep 2019 18:07:30 +0000 (21:07 +0300)
committerAlexander Korotkov <akorotkov@postgresql.org>
Sun, 8 Sep 2019 18:17:31 +0000 (21:17 +0300)
commitbc67f4189a7a3381db76dbfeafca463187bfe87a
tree8e023cb835f36a9fd3eae8e4e8f2c2ba6167a120
parentb6d72ddd5fbf3f6eb79597ab0c8ec3aaa7c16805
Fix handling Inf and Nan values in GiST pairing heap comparator

Previously plain float comparison was used in GiST pairing heap.  Such
comparison doesn't provide proper ordering for value sets containing Inf and Nan
values.  This commit fixes that by usage of float8_cmp_internal().  Note, there
is remaining problem with NULL distances, which are represented as Inf in
pairing heap.  It would be fixes in subsequent commit.

Backpatch to all supported versions.

Reported-by: Andrey Borodin
Discussion: http://postgr.es/m/CAPpHfdsNvNdA0DBS%2BwMpFrgwT6C3-q50sFVGLSiuWnV3FqOJuQ%40mail.gmail.com
Author: Alexander Korotkov
Reviewed-by: Heikki Linnakangas
Backpatch-through: 9.4
src/backend/access/gist/gistscan.c
src/test/regress/expected/create_index.out