Fix under-parenthesized XLogRecHasBlockRef() macro.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 20 Apr 2021 20:58:30 +0000 (16:58 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 20 Apr 2021 21:01:49 +0000 (17:01 -0400)
commit9e41148229192dccc4bcc40f53af588b73d8ffea
tree3314c5c3920022d3ad4b76c66cd721a076774d87
parentdb01f797dd48f826c62e1b8eea70f11fe7ff3efc
Fix under-parenthesized XLogRecHasBlockRef() macro.

Commit f003d9f87 left this macro with inadequate (or, one could say,
too much) parenthesization.  Which was catastrophic to the correctness
of calls such as "if (!XLogRecHasBlockRef(record, 1)) ...".  There
are only a few of those, which perhaps explains why we didn't notice
immediately (with our general weakness of WAL replay testing being
another factor).  I found it by debugging intermittent replay failures
like

2021-04-08 14:33:30.191 EDT [29463] PANIC:  failed to locate backup block with ID 1
2021-04-08 14:33:30.191 EDT [29463] CONTEXT:  WAL redo at 0/95D3438 for SPGist/ADD_NODE: off 1; blkref #0: rel 1663/16384/25998, blk 1
src/include/access/xlogreader.h