Don't leak malloc'd error string in libpqrcv_check_conninfo().
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 19 Mar 2021 02:21:58 +0000 (22:21 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 19 Mar 2021 02:22:47 +0000 (22:22 -0400)
commit9bacdf9f536a3720976ae258238cb46c691ce9b2
treee1ff00d0333358f5bfb02d55125840c1e6c86af0
parent377b7a83007d277d32ef19f7c7590c8668d504cb
Don't leak malloc'd error string in libpqrcv_check_conninfo().

We leaked the error report from PQconninfoParse, when there was
one.  It seems unlikely that real usage patterns would repeat
the failure often enough to create serious bloat, but let's
back-patch anyway to keep the code similar in all branches.

Found via valgrind testing.
Back-patch to v10 where this code was added.

Discussion: http://postgr.es/m/3816764.1616104288@sss.pgh.pa.us
src/backend/replication/libpqwalreceiver/libpqwalreceiver.c