Fix setrefs.c's failure to do expression processing on prune steps.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 17 Jan 2025 01:40:07 +0000 (20:40 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 17 Jan 2025 01:40:07 +0000 (20:40 -0500)
commit5f725648fa3b29ffcf25c8c5123cdd9a36642862
treea552374d5edc7b317f7bbf3682e29da515318e17
parent50406b15540cee90d3038229829b417cbd755bd7
Fix setrefs.c's failure to do expression processing on prune steps.

We should run the expression subtrees of PartitionedRelPruneInfo
structs through fix_scan_expr.  Failure to do so means that
AlternativeSubPlans within those expressions won't be cleaned up
properly, resulting in "unrecognized node type" errors since v14.

It seems fairly likely that at least some of the other steps done
by fix_scan_expr are important here as well, resulting in as-yet-
undetected bugs.  Therefore, I've chosen to back-patch this to
all supported branches including v13, even though the known
symptom doesn't manifest in v13.

Per bug #18778 from Alexander Lakhin.

Discussion: http://postgr.es/m/18778-24cd399df6c806af@postgresql.org
src/backend/optimizer/plan/setrefs.c
src/test/regress/expected/partition_prune.out
src/test/regress/sql/partition_prune.sql