Fix arrays comparison in CompareOpclassOptions()
authorAlexander Korotkov <akorotkov@postgresql.org>
Mon, 11 Nov 2024 23:44:20 +0000 (01:44 +0200)
committerAlexander Korotkov <akorotkov@postgresql.org>
Mon, 11 Nov 2024 23:54:38 +0000 (01:54 +0200)
commit5411e821386ce5c9ec794bbc9540c7c4a1acaa46
treea24e74c2c01ee2a3997f30113b5f2e92cd7dd1b0
parent64ecc00908b7557afa911c15bb342ff06845bb19
Fix arrays comparison in CompareOpclassOptions()

The current code calls array_eq() and does not provide FmgrInfo.  This commit
provides initialization of FmgrInfo and uses C collation as the safe option
for text comparison because we don't know anything about the semantics of
opclass options.

Backpatch to 13, where opclass options were introduced.

Reported-by: Nicolas Maus
Discussion: http://postgr.es/m/18692-72ea398df3ec6712%40postgresql.org
Backpatch-through: 13
contrib/pg_trgm/expected/pg_trgm.out
contrib/pg_trgm/sql/pg_trgm.sql
src/backend/commands/indexcmds.c