Set all variable-length fields of pg_attribute to null on column drop
authorPeter Eisentraut <peter@eisentraut.org>
Fri, 22 Dec 2023 20:44:55 +0000 (21:44 +0100)
committerPeter Eisentraut <peter@eisentraut.org>
Fri, 22 Dec 2023 20:44:55 +0000 (21:44 +0100)
commit3e2e0d5ad7fcb89d18a71cbfc885ef184e1b6f2e
treeda03307ed09a28bcfa129abaf0c98e9fcddf07a5
parente2b73f4a4de6c2df6a1e623ad06b42f1bb2471ad
Set all variable-length fields of pg_attribute to null on column drop

When a column is dropped, the fields attacl, attoptions, and
attfdwoptions were kept unchanged.  This is probably harmless, but it
seems wasteful, and leaves potentially dangling data lying around (for
example, attacl could contain references to users that are later also
dropped).

Change this to set those fields to null when a column is marked as
dropped.

Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: http://www.postgresql.org/message-id/flat/249d819d-1763-4580-8110-0bf91a0f08b7@eisentraut.org
src/backend/catalog/heap.c