For inplace update, send nontransactional invalidations.
authorNoah Misch <noah@leadboat.com>
Fri, 25 Oct 2024 13:51:02 +0000 (06:51 -0700)
committerNoah Misch <noah@leadboat.com>
Fri, 25 Oct 2024 13:51:08 +0000 (06:51 -0700)
commit0ea9d40a667960ad5cca5f537bb88d3bf6038379
tree33243fa2429ffcedb62adef8e4bd10c159aeb22d
parent67f30c79a1c17417029b3c1cd1d94aa56d5fb691
For inplace update, send nontransactional invalidations.

The inplace update survives ROLLBACK.  The inval didn't, so another
backend's DDL could then update the row without incorporating the
inplace update.  In the test this fixes, a mix of CREATE INDEX and ALTER
TABLE resulted in a table with an index, yet relhasindex=f.  That is a
source of index corruption.  Back-patch to v12 (all supported versions).
The back branch versions don't change WAL, because those branches just
added end-of-recovery SIResetAll().  All branches change the ABI of
extern function PrepareToInvalidateCacheTuple().  No PGXN extension
calls that, and there's no apparent use case in extensions.

Reviewed by Nitin Motiani and (in earlier versions) Andres Freund.

Discussion: http://postgr.es/m/20240523000548.58.nmisch@google.com
src/backend/access/heap/heapam.c
src/backend/access/transam/xact.c
src/backend/catalog/index.c
src/backend/replication/logical/decode.c
src/backend/utils/cache/catcache.c
src/backend/utils/cache/inval.c
src/backend/utils/cache/syscache.c
src/include/utils/catcache.h
src/include/utils/inval.h
src/test/isolation/expected/inplace-inval.out
src/test/isolation/specs/inplace-inval.spec