Fix ALTER DEFAULT PRIVILEGES with duplicated objects
authorMichael Paquier <michael@paquier.xyz>
Wed, 20 Jan 2021 02:39:35 +0000 (11:39 +0900)
committerMichael Paquier <michael@paquier.xyz>
Wed, 20 Jan 2021 02:39:35 +0000 (11:39 +0900)
commit0ddb529cf3e25afd94abf85aa3688b9d9063897c
tree82945f26cc62717386cc887854174ff7d291f4c3
parent0ab177bec1c546d2b98b5934a817b23bcc335ca9
Fix ALTER DEFAULT PRIVILEGES with duplicated objects

Specifying duplicated objects in this command would lead to unique
constraint violations in pg_default_acl or "tuple already updated by
self" errors.  Similarly to GRANT/REVOKE, increment the command ID after
each subcommand processing to allow this case to work transparently.

A regression test is added by tweaking one of the existing queries of
privileges.sql to stress this case.

Reported-by: Andrus
Author: Michael Paquier
Reviewed-by: Álvaro Herrera
Discussion: http://postgr.es/m/ae2a7dc1-9d71-8cba-3bb9-e4cb7eb1f44e@hot.ee
Backpatch-through: 9.5
src/backend/catalog/aclchk.c
src/test/regress/expected/privileges.out
src/test/regress/sql/privileges.sql