Skip to content

Commit ab7ddcb

Browse files
committed
avoid “please“, use “see” instead of “refer to”
1 parent 5a0daae commit ab7ddcb

File tree

77 files changed

+126
-137
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

77 files changed

+126
-137
lines changed

.github/styles/Vaadin/Please.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
extends: existence
2+
message: "Avoid using “please”. Focus on instructing the reader, instead of pleading."
3+
ignorecase: true
4+
level: suggestion
5+
tokens:
6+
- please

.github/styles/Vaadin/ReferTo.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
extends: substitution
2+
message: "Prefer '%s' over '%s' when linking to another documentation resource."
3+
level: suggestion
4+
ignorecase: true
5+
action:
6+
name: replace
7+
swap:
8+
refer to: see
9+
please refer to: see
10+
check: see
11+
please check: see

articles/advanced/browser-access.asciidoc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ For example:
2323
----
2424
UI.getCurrent().getPage().fetchCurrentURL(currentUrl -> {
2525
// This is your own method that you may do something with the url.
26-
// Please note that this method runs asynchronously
26+
// Note that this method runs asynchronously
2727
storeCurrentURL(currentUrl);
2828
});
2929
----
@@ -43,7 +43,7 @@ For example, the following can be used to get the screen width:
4343
----
4444
UI.getCurrent().getPage().retrieveExtendedClientDetails(details -> {
4545
// This is your own method that you may do something with the screen width.
46-
// Please note that this method runs asynchronously
46+
// Note that this method runs asynchronously
4747
handleScreenWidth(details.getScreenWidth());
4848
});
4949
----
@@ -96,4 +96,3 @@ page.addBrowserWindowResizeListener(
9696

9797
[.discussion-id]
9898
0DF2CC14-4401-49E4-B97D-920CAFEAAF8D
99-

articles/advanced/custom-error-handler.asciidoc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public class CustomErrorHandler implements ErrorHandler {
2626
if(UI.getCurrent() != null) {
2727
UI.getCurrent().access(() -> {
2828
Notification.show("An internal error has occurred." +
29-
"Please contact support.");
29+
"Contact support for assistance.");
3030
});
3131
}
3232
}
@@ -46,4 +46,3 @@ See the <<session-and-ui-init-listener#,Session and UI Listeners>> article to le
4646

4747
[.discussion-id]
4848
98746DB3-C9AC-42AD-A43D-D79F09B2155E
49-

articles/binding-data/components-binder-beans.asciidoc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ binder.bind(streetAddressField, "address.street");
3030
binder.forField(yearOfBirthField)
3131
.withConverter(
3232
new StringToIntegerConverter(
33-
"Please enter a number"))
33+
"Enter a number"))
3434
.bind("yearOfBirth");
3535
----
3636

@@ -265,4 +265,3 @@ binder.setRequiredConfigurator(
265265

266266
[.discussion-id]
267267
D8AE5573-0248-4DBC-A58E-CBEA8E8F0957
268-

articles/binding-data/components-binder-validation.asciidoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ binder.forField(yearOfBirthField)
242242
String::valueOf,
243243
// Text to use instead of the
244244
// NumberFormatException message
245-
"Please enter a number")
245+
"Enter a number")
246246
.bind(Person::getYearOfBirth,
247247
Person::setYearOfBirth);
248248
----
@@ -363,7 +363,7 @@ public class DatePickerDemo implements HasValidator<LocalDate> /*, HasValue<...>
363363
----
364364
<1> The validator instance returned by [methodname]`getDefaultValidator()` gets called every time the binding instance validates/revalidates (as a part of the validator chain of the binding).
365365

366-
For a complete implementation, please refer to http://github.com/vaadin/flow-components/blob/master/vaadin-date-picker-flow-parent/vaadin-date-picker-flow/src/main/java/com/vaadin/flow/component/datepicker/DatePicker.java[DatePicker's source code] as an example.
366+
For a complete implementation see, for example, the http://github.com/vaadin/flow-components/blob/master/vaadin-date-picker-flow-parent/vaadin-date-picker-flow/src/main/java/com/vaadin/flow/component/datepicker/DatePicker.java[`DatePicker` source code].
367367

368368

369369
[.discussion-id]

articles/components/charts/configuration.asciidoc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,7 @@ A chart can have more than one Y-axis, usually when different series displayed
201201
in a graph have different units or scales. The association of a data series with
202202
an axis is done in the data series object with [methodname]`setyAxis()`.
203203

204-
For a complete reference of the many configuration parameters for the axes,
205-
please refer to the JavaDoc API documentation of Charts.
204+
For a complete reference of the many configuration parameters for the axes, see the Charts Javadoc API documentation.
206205

207206
[[charts.configuration.axes.type]]
208207
=== Axis Type
@@ -309,7 +308,7 @@ X offset defaults to 0, but Y to [literal]#++null++#, which enables automatic po
309308
Gauge, pie, and polar charts allow additional properties.
310309

311310
For a complete reference of the many configuration parameters for the labels,
312-
please refer to the JavaDoc API documentation of Charts.
311+
see the Charts Javadoc API documentation.
313312

314313

315314
[[charts.configuration.axes.extremes]]
@@ -418,4 +417,3 @@ floating-point precision for the values.
418417

419418
[.discussion-id]
420419
5FCAE9D2-4CEB-4600-A33D-A6082E36BC4F
421-

articles/components/charts/css-styling.asciidoc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ See a <<{articles}/components/charts#,demo of the variants>>.
2727

2828
== Java Styling
2929
The default styling mode in Flow applications uses the Java API.
30-
Please see the link:http://vaadin.com/api/platform/com/vaadin/flow/component/charts/model/style/package-summary.html[Java API reference] for details.
30+
See the link:http://vaadin.com/api/platform/com/vaadin/flow/component/charts/model/style/package-summary.html[Java API reference] for details.
3131

3232

3333
[[css.styling]]
@@ -142,4 +142,3 @@ image::img/css-styling2.png[]
142142

143143
[.discussion-id]
144144
3E5B31FB-DF25-4D1E-80EB-7AB485C7B566
145-

articles/components/charts/migrating-from-earlier-versions.asciidoc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ Configuration conf = chart.getConfiguration();
5151
conf.getChart().setStyledMode(true);
5252
----
5353

54-
For more detailed instructions, please check the
54+
For more detailed instructions, see the
5555
<<css-styling#,"CSS Styling guide">>
5656

5757

@@ -94,4 +94,3 @@ on this page.
9494

9595
[.discussion-id]
9696
CA191212-B228-4F07-9F40-BC0C68F84FA0
97-

articles/components/charts/svg-generator.asciidoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,9 @@ Add the `vaadin-charts-flow-svg-generator` dependency to your project's `pom.xml
2323
----
2424

2525
.Node.js required
26-
NOTE: Node.js must be installed for the generator to work.
27-
Please see the configuration instructions in <<{articles}/configuration/node-js#,Installing Node.js>>.
26+
[NOTE]
27+
Node.js must be installed for the generator to work.
28+
See the configuration instructions in <<{articles}/configuration/node-js#,Installing Node.js>>.
2829

2930
== Using the Generator
3031

@@ -126,4 +127,3 @@ add(div);
126127

127128
[.discussion-id]
128129
C8510402-621D-437D-ADD9-E219BBDB532D
129-

0 commit comments

Comments
 (0)