Skip to content

Commit a3ae9a4

Browse files
committed
first commit
0 parents  commit a3ae9a4

File tree

14 files changed

+15460
-0
lines changed

14 files changed

+15460
-0
lines changed

.gitignore

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# See http://help.github.com/articles/ignoring-files/ for more about ignoring files.
2+
3+
# dependencies
4+
/node_modules
5+
6+
# testing
7+
/coverage
8+
9+
# production
10+
/build
11+
12+
# misc
13+
.DS_Store
14+
.env.local
15+
.env.development.local
16+
.env.test.local
17+
.env.production.local
18+
19+
npm-debug.log*
20+
yarn-debug.log*
21+
yarn-error.log*

.prettierrc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"semi": true,
3+
"trailingComma": "all",
4+
"singleQuote": true,
5+
"printWidth": 70,
6+
}

.travis.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
language: node_js
2+
3+
node_js:
4+
- stable
5+
6+
install:
7+
- npm install
8+
9+
script:
10+
- npm test

README.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# react-asynchronous-request-setstate-unmounted-component
2+
3+
[![Build Status](http://travis-ci.org/the-road-to-learn-react/react-asynchronous-request-setstate-unmounted-component.svg?branch=master)](http://travis-ci.org/the-road-to-learn-react/react-asynchronous-request-setstate-unmounted-component) [![Slack](http://slack-the-road-to-learn-react.wieruch.com/badge.svg)](http://slack-the-road-to-learn-react.wieruch.com/)
4+
5+
Showcasing how to prevent to set state on unmounted React components when having an asynchronous request in place. [Read more about it](http://www.robinwieruch.de/react-warning-cant-call-setstate-on-an-unmounted-component).
6+
7+
## Installation
8+
9+
* `git clone git@github.com:the-road-to-learn-react/react-asynchronous-request-setstate-unmounted-component.git`
10+
* cd react-asynchronous-request-setstate-unmounted-component
11+
* npm install
12+
* npm start
13+
* visit `http://localhost:3000`

package-lock.json

Lines changed: 15097 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
{
2+
"name": "react-asynchronous-request-setstate-unmounted-component",
3+
"version": "0.1.0",
4+
"private": true,
5+
"dependencies": {
6+
"axios": "^0.18.0",
7+
"react": "^16.5.2",
8+
"react-dom": "^16.5.2",
9+
"react-scripts": "2.0.4"
10+
},
11+
"scripts": {
12+
"start": "react-scripts start",
13+
"build": "react-scripts build",
14+
"test": "react-scripts test",
15+
"eject": "react-scripts eject"
16+
},
17+
"eslintConfig": {
18+
"extends": "react-app"
19+
},
20+
"browserslist": [
21+
">0.2%",
22+
"not dead",
23+
"not ie <= 11",
24+
"not op_mini all"
25+
]
26+
}

public/favicon.ico

3.78 KB
Binary file not shown.

public/index.html

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
<!DOCTYPE html>
2+
<html lang="en">
3+
<head>
4+
<meta charset="utf-8">
5+
<link rel="shortcut icon" href="%PUBLIC_URL%/favicon.ico">
6+
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
7+
<meta name="theme-color" content="#000000">
8+
<!--
9+
manifest.json provides metadata used when your web app is added to the
10+
homescreen on Android. See http://developers.google.com/web/fundamentals/engage-and-retain/web-app-manifest/
11+
-->
12+
<link rel="manifest" href="%PUBLIC_URL%/manifest.json">
13+
<!--
14+
Notice the use of %PUBLIC_URL% in the tags above.
15+
It will be replaced with the URL of the `public` folder during the build.
16+
Only files inside the `public` folder can be referenced from the HTML.
17+
18+
Unlike "/favicon.ico" or "favicon.ico", "%PUBLIC_URL%/favicon.ico" will
19+
work correctly both with client-side routing and a non-root public URL.
20+
Learn how to configure a non-root public URL by running `npm run build`.
21+
-->
22+
<title>React App</title>
23+
</head>
24+
<body>
25+
<noscript>
26+
You need to enable JavaScript to run this app.
27+
</noscript>
28+
<div id="root"></div>
29+
<!--
30+
This HTML file is a template.
31+
If you open it directly in the browser, you will see an empty page.
32+
33+
You can add webfonts, meta tags, or analytics to this file.
34+
The build step will place the bundled scripts into the <body> tag.
35+
36+
To begin the development, run `npm start` or `yarn start`.
37+
To create a production bundle, use `npm run build` or `yarn build`.
38+
-->
39+
</body>
40+
</html>

public/manifest.json

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
{
2+
"short_name": "React App",
3+
"name": "Create React App Sample",
4+
"icons": [
5+
{
6+
"src": "favicon.ico",
7+
"sizes": "64x64 32x32 24x24 16x16",
8+
"type": "image/x-icon"
9+
}
10+
],
11+
"start_url": ".",
12+
"display": "standalone",
13+
"theme_color": "#000000",
14+
"background_color": "#ffffff"
15+
}

src/App.js

Lines changed: 70 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
import React, { Component } from 'react';
2+
import axios from 'axios';
3+
4+
class App extends Component {
5+
constructor(props) {
6+
super(props);
7+
8+
this.state = {
9+
showNews: true,
10+
};
11+
}
12+
13+
onToggle = () => {
14+
this.setState(state => ({ showNews: !state.showNews }));
15+
};
16+
17+
render() {
18+
return (
19+
<div>
20+
<button type="button" onClick={this.onToggle}>
21+
Toggle
22+
</button>
23+
24+
{this.state.showNews && <News />}
25+
</div>
26+
);
27+
}
28+
}
29+
30+
class News extends Component {
31+
_isMounted = false;
32+
33+
constructor(props) {
34+
super(props);
35+
36+
this.state = {
37+
news: [],
38+
};
39+
}
40+
41+
componentDidMount() {
42+
this._isMounted = true;
43+
44+
axios
45+
.get('http://hn.algolia.com/api/v1/search?query=react')
46+
.then(result => {
47+
if (this._isMounted) {
48+
this.setState({
49+
news: result.data.hits,
50+
});
51+
}
52+
});
53+
}
54+
55+
componentWillUnmount() {
56+
this._isMounted = false;
57+
}
58+
59+
render() {
60+
return (
61+
<ul>
62+
{this.state.news.map(topic => (
63+
<li key={topic.objectID}>{topic.title}</li>
64+
))}
65+
</ul>
66+
);
67+
}
68+
}
69+
70+
export default App;

0 commit comments

Comments
 (0)