[LLAPI] getter functions for score, language and stopwords list #2184

ashtul · 2021-08-16T13:56:40Z

src/stopwords.c

codecov · 2021-08-16T14:15:03Z

Codecov Report

Merging #2184 (03cb5de) into master (05e4d4d) will increase coverage by 0.02%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##           master    #2184      +/-   ##
==========================================
+ Coverage   80.42%   80.45%   +0.02%     
==========================================
  Files         150      150              
  Lines       22097    22123      +26     
==========================================
+ Hits        17772    17798      +26     
  Misses       4325     4325

Impacted Files	Coverage Δ
src/stopwords.c	`87.61% <91.66%> (+0.52%)`	⬆️
src/document_basic.c	`82.78% <100.00%> (ø)`
src/redisearch_api.c	`81.92% <100.00%> (+0.76%)`	⬆️
src/rules.c	`81.09% <100.00%> (ø)`
src/spec.c	`84.70% <100.00%> (ø)`
src/stemmer.c	`69.30% <0.00%> (+0.99%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e4d4d...03cb5de. Read the comment docs.

src/redisearch_api.c

src/stopwords.c

MeirShpilraien

👍
Some questions and comments

MeirShpilraien · 2021-08-17T10:55:37Z

src/redisearch_api.c

@@ -33,6 +33,12 @@ IndexSpec* RediSearch_CreateIndex(const char* name, const RSIndexOptions* option
    spec->indexer = NewIndexer(spec);
  }

+  if (options->score || options->lang) {


Isn't it better to get the score_default and lang_default out of the rule. There is no real meaning for rule when used from LLAPI...

Since this requires a change to rdb, issue #2185 was opened to be done next time the rdb version is changed

* [LLAPI] get score, language and stopwords list * change API per review * add score and language to RSIndexOptions * fix sanitiser (cherry picked from commit 3ddf90e)

… (#2186) * [LLAPI] get score, language and stopwords list * change API per review * add score and language to RSIndexOptions * fix sanitiser (cherry picked from commit 3ddf90e)

[LLAPI] get score, language and stopwords list

004ac86

ashtul requested review from rafie and MeirShpilraien August 16, 2021 13:56

rafie reviewed Aug 16, 2021

View reviewed changes

src/stopwords.c Outdated Show resolved Hide resolved