Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: php-http/cache-plugin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0f7540758755efa2d68de242b1cfe60a10be8c3c
Choose a base ref
...
head repository: php-http/cache-plugin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5c1599ca0358a2f9d383a9340e7acc6f923bf5b6
Choose a head ref
  • 9 commits
  • 3 files changed
  • 2 contributors

Commits on Nov 25, 2019

  1. Added blacklisted_paths option 

     - adds a list of strings (regular expressions) to describe patterns of paths not to be cached.
    Till Hildebrandt committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    47ac710 View commit details
    Browse the repository at this point in the history

  2. Fix CI

    Till Hildebrandt committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    5fcfc39 View commit details
    Browse the repository at this point in the history

  3. Fix CI # 2 

     - honestly, the lengths of a line should be fixed.
    Till Hildebrandt committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    0ed5c85 View commit details
    Browse the repository at this point in the history

  4. Fix CI # 3 

     - that has been a fine restriction
    Till Hildebrandt committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    a9e1d11 View commit details
    Browse the repository at this point in the history

  5. Fixing Pull Request Requests 

     - outsourced checking of blacklisted_paths to new method "isCacheableRequest"
 - removed related functionality from "isCacheable"
 - removed obsolete comment
    Till Hildebrandt committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    005d609 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2019

  1. Fixing Pull Request Requests 

     - added spec tests for blacklisted paths
  - it_does_not_store_responses_of_requests_to_blacklisted_paths
  - it_stores_responses_of_requests_not_in_blacklisted_paths
    Till Hildebrandt committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    817a4d8 View commit details
    Browse the repository at this point in the history

  2. Fixing CI

    Till Hildebrandt committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    ba4b1aa View commit details
    Browse the repository at this point in the history

  3. Implemented Feedback 

     - removed unnecessary string concatenation
 - set isCacheableRequest to private
    Till Hildebrandt committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    61aab95 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. Merge pull request #61 from nobYsDarling/feature/blacklisted-paths-25… 

    …112019

Added blacklisted_paths option
    @dbu
    dbu authored Nov 27, 2019
    Configuration menu
    Copy the full SHA
    5c1599c View commit details
    Browse the repository at this point in the history
Loading