Skip to content

Conversation

@eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Mar 21, 2021

What does this PR do?

Adds the ability to automatically configure usage of Elastic's OpenTracing bridge in systems using ServiceLoader. An example for such system is tracer-resolver, which is used by various OpenTracing libraries, for example the Apache Camel OpenTracing component.

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • I have made corresponding changes to the documentation

@ghost
Copy link

ghost commented Mar 21, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user eyalkoren

  • Start Time: 2021-03-22T12:39:04.523+0000

  • Duration: 52 min 0 sec

  • Commit: dd34466

Test stats 🧪

Test Results
Failed 0
Passed 1901
Skipped 15
Total 1916

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1901
Skipped 15
Total 1916

@codecov-io
Copy link

Codecov Report

Merging #1708 (dd34466) into master (789406b) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1708      +/-   ##
============================================
+ Coverage     58.32%   58.33%   +0.01%     
- Complexity      109     2383    +2274     
============================================
  Files           430      430              
  Lines         18899    18899              
  Branches       2617     2618       +1     
============================================
+ Hits          11022    11025       +3     
  Misses         7102     7102              
+ Partials        775      772       -3     
Impacted Files Coverage Δ Complexity Δ
...tic/apm/agent/report/ssl/TLSFallbackSSLSocket.java 39.13% <0.00%> (-2.18%) 20.00% <0.00%> (+20.00%) ⬇️
...o/elastic/apm/agent/profiler/SamplingProfiler.java 73.04% <0.00%> (+0.23%) 0.00% <0.00%> (ø%)
...ic/apm/agent/profiler/collections/LongHashSet.java 18.25% <0.00%> (+0.39%) 0.00% <0.00%> (ø%)
.../bci/bytebuddy/SoftlyReferencingTypePoolCache.java 93.75% <0.00%> (+12.50%) 9.00% <0.00%> (+9.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 789406b...dd34466. Read the comment docs.

@eyalkoren eyalkoren merged commit f594eca into elastic:master Mar 22, 2021
@eyalkoren eyalkoren deleted the opentracing-ServiceLoader-support branch March 22, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants