lazy-load jdbc helper #1409
Merged
lazy-load jdbc helper #1409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
eyalkoren
reviewed
Sep 22, 2020
...ent-plugins/apm-jdbc-plugin/src/main/java/co/elastic/apm/agent/jdbc/JdbcInstrumentation.java
Outdated
Show resolved
Hide resolved
felixbarny
reviewed
Sep 28, 2020
| } | ||
|
|
||
| protected synchronized static JdbcHelper getJdbcHelper() { | ||
| // lazily initialize helper to prevent trying to load classes in java.sql package with the bootstrap classloader |
Member
There was a problem hiding this comment.
Is that an indication that we should more strictly separate advices from element matches?
Member
Author
There was a problem hiding this comment.
I would say yes, separation would be better. In the same category, there is getAdviceClass() method that returns the advice class loaded from agent/bootstrap classloader when in practice we only use class name and then load it in child-first plugin classloader. We already discussed that a bit with @eyalkoren last week.
...ent-plugins/apm-jdbc-plugin/src/main/java/co/elastic/apm/agent/jdbc/JdbcInstrumentation.java
Outdated
Show resolved
Hide resolved
eyalkoren
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
JDBC instrumentation fails on some environments when active.
This appears to be a side-effect of migration to new plugin architecture introduced in version 1.18.0.
We haven't been able to reproduce this directly, but changes have been confirmed to work where it used to happen.
Checklist