Generic/InlineControlStructure: improve code coverage

Author: rodrigoprimo

src/Standards/Generic/Tests/ControlStructures/InlineControlStructureUnitTest.1.inc

@@ -289,3 +289,13 @@ if (false) {
 } else ($shouldTriggerSniff);
 
 foreach ($array as $shouldNotTriggerSniff);
+
+do echo $i++; while ($i < 5);
+
+// phpcs:set Generic.ControlStructures.InlineControlStructure error false
+if ($something) echo 'hello';
+// phpcs:set Generic.ControlStructures.InlineControlStructure error true
+
+if ($noSpaceAfterClosingParenthesis)echo 'hello';
+
+do ; while ($i > 5);

src/Standards/Generic/Tests/ControlStructures/InlineControlStructureUnitTest.1.inc.fixed

@@ -326,3 +326,17 @@ if (false) {
 }
 
 foreach ($array as $shouldNotTriggerSniff);
+
+do { echo $i++;
+} while ($i < 5);
+
+// phpcs:set Generic.ControlStructures.InlineControlStructure error false
+if ($something) { echo 'hello';
+}
+// phpcs:set Generic.ControlStructures.InlineControlStructure error true
+
+if ($noSpaceAfterClosingParenthesis) { echo 'hello';
+}
+
+do { ;
+} while ($i > 5);

src/Standards/Generic/Tests/ControlStructures/InlineControlStructureUnitTest.10.inc

@@ -0,0 +1,9 @@
+<?php
+
+// This should be the only test in this file.
+// There should be only empty tokens after the scope closer of the "if" token.
+
+for ($i = 0; $i < 5; $i++)
+    if ($i === 3) {
+        echo $i;
+    }

src/Standards/Generic/Tests/ControlStructures/InlineControlStructureUnitTest.10.inc.fixed

@@ -0,0 +1,10 @@
+<?php
+
+// This should be the only test in this file.
+// There should be only empty tokens after the scope closer of the "if" token.
+
+for ($i = 0; $i < 5; $i++) {
+    if ($i === 3) {
+        echo $i;
+    }
+}

src/Standards/Generic/Tests/ControlStructures/InlineControlStructureUnitTest.8.inc

@@ -0,0 +1,7 @@
+<?php
+
+// Intentional parse error (nothing after for closing parenthesis).
+// This should be the only test in this file.
+// Testing that the sniff is *not* triggered.
+
+for ($i = 0; $i < 5; $i++)

src/Standards/Generic/Tests/ControlStructures/InlineControlStructureUnitTest.9.inc

@@ -0,0 +1,7 @@
+<?php
+
+// Intentional parse error (nothing after while closing parenthesis).
+// This should be the only test in this file.
+// Testing that the sniff is *not* triggered.
+
+while ($i < 5)

src/Standards/Generic/Tests/ControlStructures/InlineControlStructureUnitTest.php

@@ -80,6 +80,14 @@ public function getErrorList($testFile='')
                 269 => 1,
                 278 => 1,
                 289 => 1,
+                293 => 1,
+                299 => 1,
+                301 => 1,
+            ];
+
+        case 'InlineControlStructureUnitTest.10.inc':
+            return [
+                6 => 1,
             ];
 
         case 'InlineControlStructureUnitTest.1.js':
@@ -108,11 +116,21 @@ public function getErrorList($testFile='')
      * The key of the array should represent the line number and the value
      * should represent the number of warnings that should occur on that line.
      *
+     * @param string $testFile The name of the file being tested.
+     *
      * @return array<int, int>
      */
-    public function getWarningList()
+    public function getWarningList($testFile='')
     {
-        return [];
+        switch ($testFile) {
+        case 'InlineControlStructureUnitTest.1.inc':
+            return [
+                296 => 1,
+            ];
+
+        default:
+            return [];
+        }
 
     }//end getWarningList()